Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Ruby 3 #681

Closed
wants to merge 1 commit into from
Closed

Test with Ruby 3 #681

wants to merge 1 commit into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 10, 2024

This tries out #519 together with theforeman/foreman#9871 to verify the test suite on Ruby 3.

@ekohl
Copy link
Member Author

ekohl commented Feb 1, 2024

Rebased to be based on theforeman/foreman#9989.

@ekohl
Copy link
Member Author

ekohl commented Feb 1, 2024

I wonder why this fails. In the console you see a deprecation warning, but that shoudn't be fatal. In the PostgreSQL log you do see errors about tables not existing so I wonder if that's the real reason.

@ofedoren
Copy link
Member

ofedoren commented Feb 2, 2024

Hmm, not sure either. Maybe it's somehow related to webpack? I mean, some test failed for me locally until I run bundle exec rake webpack:compile. Otherwise it was green (on Ruby 3 with tasks/dynflow changes, didn't test otherwise).

@ekohl ekohl closed this Mar 5, 2024
@ekohl ekohl deleted the ruby-3 branch March 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants